fix: Mount /var/folders to finch vm

[vsiravar]

Issue #, if available:
#297

Description of changes:
Mount /var/folders into finch vm automatically to improve compatibility with docker.

Docker mount directories

Testing done:
Yes

• I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[weikequ]

Thanks for this! I think this is a great idea as it might help with getting eventual vscode integration as well. See issue: #387. Is there any security concerns with respect to the vm/containers having access to these temp folders?

Edit: Seems like there are some e2e tests failing, mainly:

Run a container image [BeforeEach] when running a container with volume flags

[vsiravar]

Thanks for this! I think this is a great idea as it might help with getting eventual vscode integration as well. See issue: #387. Is there any security concerns with respect to the vm/containers having access to these temp folders?

Thanks for the additional context about vscode integration, it would very cool to have finch integrate with vscode.

Regarding security concerns, there is not a lot of Apple Documentation about /var/folders but I did find some useful posts

• /var/folders stores temporary files and caches and it's ok to delete everything in it except the folder itself which is not possible to do from finch since the folder belongs to root. https://apple.stackexchange.com/questions/176371/can-i-delete-files-or-folders-from-private-var-folders
• lima enforces that finch can't be run as root so a container can't modify files that don't belong to the user that launched the container from the host

[mharwani]

Thanks for this change. I know /var/folders was chosen specifically to address #297, but are there any concerns with adding other directories listed in the screenshot as well?

[vsiravar]

Thanks for this change. I know /var/folders was chosen specifically to address #297, but are there any concerns with adding other directories listed in the screenshot as well?

Apart from /tmp which would hide the system /tmp in the vm all others can be mounted. lima-vm/lima#571. To bypass mounting /tmp from macOS we can mount /private/tmp since readlink /tmp =>
private/tmp. Maybe can add this to a subsequent PR.