feat: add finch version output to support-bundle #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatbora90
force-pushed
the
add-version-to-support
branch
from
cc02ef3
to
a2c089d
Compare
swagatbora90
changed the title
pendo324
reviewed
Oct 3, 2024
swagatbora90
force-pushed
the
add-version-to-support
branch
2 times, most recently
from
0d23015
to
a16be78
Compare
pendo324
approved these changes
Oct 4, 2024
Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
add-version-to-support
branch
from
a16be78
to
77fa357
Compare
Kern--
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumps finch version output to a file when generating finch support-bundle
Testing done:
make test-unitandmake test-e2eLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.