ci(release): fix release build generation #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
1 task
austinvazquez
pushed a commit
that referenced
this pull request
Jul 2, 2024
Issue #, if available: - MSI release builds are broken, as seen in [this automated run](https://github.com/runfinch/finch/actions/runs/9764308833/job/26959973907) - Debugged by looking at the lima stderr logs and found: ``` {"level":"fatal","msg":"failed to download \"file://C:/actions-runner/_work/finch/finch/_output/os/finch-rootfs-production-amd64-1719439880.tar.gz\": open C:/actions-runner/_work/finch/finch/_output/os/finch-rootfs-production-amd64-1719439880.tar.gz: The system cannot find the path specified.","time":"2024-07-02T19:14:36Z"} ``` *Description of changes:* - This regression occurred because `FINCH_ROOTFS_LOCATION_ROOT` was removed from the Makefile during recent refactoring. `FINCH_ROOTFS_LOCATION_ROOT` was used to override the path of the rootfs file used at runtime by Lima. Removing it means that release builds, which are installed to different locations than dev builds, will not function. This PR makes it so Windows follows the macOS Makefile variable name (`FINCH_OS_IMAGE_LOCATION_ROOT`), as seen in #1007 *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Recently in #969, the Makefile was refactored significantly, and the mechanism that was used to override the installation directory was removed (used here). This just adds that mechanism back. There could be a better way to do this, but for now just reverting back to how it was done before the recent change.
Testing done:
Tested locally. The
_output/os/finch.yamlfile correctly used/Applications/Finch/, which was the path I overwrote, as a prefixLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.