Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ShellCheck lint warnings #550

Closed
austinvazquez opened this issue Aug 31, 2023 · 2 comments
Closed

Resolve ShellCheck lint warnings #550

austinvazquez opened this issue Aug 31, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@austinvazquez
Copy link
Member

What is the problem you're trying to solve?.
#458 added ShellCheck to Finch CI for linting Finch shell scripts. The step is currently non-critical due to some lingering non-trivial lint warnings.

Describe the feature you'd like
It would be nice to resolve the remaining warnings and make the CI step critical.

Additional context
N/A
@austinvazquez austinvazquez added the good first issue Good for newcomers label Sep 18, 2023
@RiverPhillips
Copy link
Contributor

I'd like to look into this

@RiverPhillips RiverPhillips mentioned this issue Nov 4, 2023
Merged
1 task
KevinLiAWS pushed a commit that referenced this issue Nov 7, 2023
@RiverPhillips
fix: resolve shellcheck warnings (#684)
d9f695a 
Issue #, if available: #550

*Description of changes:* Resolves Shellcheck warnings (Some style
issues still remain). Requires Shellcheck to pass as part of the CI
process

*Testing done:* Shellcheck ran locally



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: River Phillips <[email protected]>
@mharwani
Copy link
Member

Issue is fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mharwani @RiverPhillips @austinvazquez