fix: resolve shellcheck warnings (#684)

Issue #, if available: #550

*Description of changes:* Resolves Shellcheck warnings (Some style
issues still remain). Requires Shellcheck to pass as part of the CI
process

*Testing done:* Shellcheck ran locally



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: River Phillips <[email protected]>

.github/workflows/ci.yaml

@@ -72,7 +72,8 @@ jobs:
         uses: ludeeus/[email protected]
         with:
           version: v0.9.0 
-        continue-on-error: true
+          severity: warning
+        continue-on-error: false
   go-mod-tidy-check:
     runs-on: ubuntu-latest
     steps:

installer-builder/darwin/Resources/uninstall.sh

@@ -19,7 +19,7 @@ sudo pkill '^socket_vmnet'
 sudo pkill '^qemu-system-'
 sudo pkill '^limactl'
 
-if [ "$$(readlink "/usr/local/bin/finch")" = "/Applications/Finch/bin/finch" ]; then sudo rm /usr/local/bin/finch; fi
+if [ "$(readlink '/usr/local/bin/finch')" = "/Applications/Finch/bin/finch" ]; then sudo rm /usr/local/bin/finch; fi
 
 echo "[1/3] [DONE] Successfully deleted shortcut links"
 

installer-builder/tools/extract-executables.sh

@@ -36,7 +36,7 @@ updateQEMUEntitlement() {
 
 #$1: the file object
 extractExecutables() {
-    for file in $(ls -a "$1")
+    for file in "$1"/{*,.*}
     do
         if [ -d "$1/$file" ];
         then

installer-builder/tools/merge-back-signed-executables.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 mergeBackSignedExecutables() {
-    for file in $(ls -a ./installer-builder/output/executables/signed/Payload/EXECUTABLES_TO_SIGN)
+    for file in ./installer-builder/output/executables/signed/Payload/EXECUTABLES_TO_SIGN/{*,.*}
     do
         if [[ $file != '.' && $file != '..' ]]
         then