Skip to content

Commit

Permalink
fix: finch exe icon and description (#645)
Browse files Browse the repository at this point in the history
Issue #, if available:

*Description of changes:*
- Upload multi resolution ico and use if for the exe icon (remove
placeholders)
- Update description because it's apparently what's used in Task Manager
for the process name

*Testing done:*



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <[email protected]>
  • Loading branch information
pendo324 authored and vsiravar committed Oct 17, 2023
1 parent 12b0803 commit 9f9f8cd
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
Binary file modified msi-builder/finch.ico
Binary file not shown.
Binary file removed winres/icon.png
Binary file not shown.
Binary file removed winres/icon16.png
Binary file not shown.
7 changes: 2 additions & 5 deletions winres/winres.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
{
"RT_GROUP_ICON": {
"APP": {
"0000": [
"icon.png",
"icon16.png"
]
"0000": "./../msi-builder/finch.ico"
}
},
"RT_MANIFEST": {
Expand Down Expand Up @@ -43,7 +40,7 @@
"0409": {
"Comments": "",
"CompanyName": "RunFinch",
"FileDescription": "An open source client for container development",
"FileDescription": "Finch",
"FileVersion": "",
"InternalName": "runfinch/finch",
"LegalCopyright": "Amazon.com, Inc. or its affiliates. All Rights Reserved",
Expand Down

0 comments on commit 9f9f8cd

Please sign in to comment.