ci: add e2e test step for windows, lint fixes, e2e corrections #1325
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # - When a third-party action is added (i.e., `uses`), please also add it to `download-licenses` in Makefile. | |
| # - When a job is added/removed/renamed, please make corresponding changes in ci-docs.yaml. | |
| name: CI | |
| on: | |
| push: | |
| branches: | |
| # TODO: revert to main on merge of windev branch with main | |
| - windev | |
| paths-ignore: | |
| - '**.md' | |
| - 'contrib/**' | |
| - '.github/CODEOWNERS' | |
| pull_request: | |
| branches: | |
| # TODO: revert to main on merge of windev branch with main | |
| - windev | |
| paths-ignore: | |
| - '**.md' | |
| - 'contrib/**' | |
| - '.github/CODEOWNERS' | |
| permissions: | |
| id-token: write | |
| contents: write | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| jobs: | |
| gen-code-no-diff: | |
| strategy: | |
| matrix: | |
| os: [macos-latest, windows-latest] | |
| runs-on: ${{ matrix.os }} | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |
| with: | |
| go-version-file: go.mod | |
| cache: true | |
| - run: make gen-code | |
| - run: git diff --exit-code | |
| unit-tests: | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: | |
| [ | |
| [windows-latest], | |
| [macos-latest], | |
| ] | |
| runs-on: ${{ matrix.os }} | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |
| with: | |
| # Since this repository is not meant to be used as a library, | |
| # we don't need to test the latest 2 major releases like Go does: https://go.dev/doc/devel/release#policy. | |
| go-version-file: go.mod | |
| cache: true | |
| - run: make test-unit | |
| # It's recommended to run golangci-lint in a job separate from other jobs (go test, etc) because different jobs run in parallel. | |
| go-linter: | |
| strategy: | |
| matrix: | |
| os: [macos-latest, windows-latest] | |
| name: lint | |
| runs-on: ${{ matrix.os }} | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |
| with: | |
| go-version-file: go.mod | |
| cache: false # caching results in tar errors that files already exist | |
| - name: golangci-lint | |
| uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0 | |
| with: | |
| # Pin the version in case all the builds start to fail at the same time. | |
| # There may not be an automatic way (e.g., dependabot) to update a specific parameter of a GitHub Action, | |
| # so we will just update it manually whenever it makes sense (e.g., a feature that we want is added). | |
| version: v1.53.3 | |
| args: --fix=false --timeout=5m --skip-dirs=(^|/)deps($|/) | |
| shellcheck: | |
| name: ShellCheck | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - name: Run ShellCheck | |
| uses: ludeeus/action-shellcheck@00cae500b08a931fb5698e11e79bfbd38e612a38 # 2.0.0 | |
| with: | |
| version: v0.9.0 | |
| continue-on-error: true | |
| go-mod-tidy-check: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |
| with: | |
| go-version-file: go.mod | |
| cache: true | |
| # TODO: Use `go mod tidy --check` after https://github.com/golang/go/issues/27005 is fixed. | |
| - run: go mod tidy | |
| - run: git diff --exit-code | |
| check-licenses: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 | |
| with: | |
| go-version-file: go.mod | |
| cache: true | |
| - run: make check-licenses | |
| e2e-tests: | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: | |
| [ | |
| [self-hosted, macos, amd64, 13, test], | |
| [self-hosted, macos, amd64, 12, test], | |
| [self-hosted, macos, arm64, 13, test], | |
| [self-hosted, macos, arm64, 12, test] | |
| ] | |
| runs-on: ${{ matrix.os }} | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| with: | |
| # We need to get all the git tags to make version injection work. See VERSION in Makefile for more detail. | |
| fetch-depth: 0 | |
| persist-credentials: false | |
| submodules: recursive | |
| - name: Set output variables | |
| id: vars | |
| run: | | |
| has_creds=${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name }} | |
| echo "has_creds=$has_creds" >> $GITHUB_OUTPUT | |
| - name: configure aws credentials | |
| uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1 | |
| if: steps.vars.outputs.has_creds == true | |
| with: | |
| role-to-assume: ${{ secrets.ROLE }} | |
| role-session-name: credhelper-test | |
| aws-region: ${{ secrets.REGION }} | |
| - name: Clean up previous files | |
| run: | | |
| sudo rm -rf /opt/finch | |
| sudo rm -rf ~/.finch | |
| sudo rm -rf ./_output | |
| if pgrep '^qemu-system'; then | |
| sudo pkill '^qemu-system' | |
| fi | |
| if pgrep '^socket_vmnet'; then | |
| sudo pkill '^socket_vmnet' | |
| fi | |
| - name: Install Rosetta 2 | |
| run: echo "A" | softwareupdate --install-rosetta || true | |
| - run: brew install go lz4 automake autoconf libtool | |
| shell: zsh {0} | |
| - name: Build project | |
| run: | | |
| export PATH="/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" | |
| make | |
| shell: zsh {0} | |
| - run: | | |
| git status | |
| git clean -f -d | |
| REGISTRY=${{ steps.vars.outputs.has_creds == true && env.REGISTRY || '' }} make test-e2e | |
| shell: zsh {0} | |
| windows-e2e-tests: | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: | |
| [ | |
| [self-hosted, windows, amd64, test], | |
| ] | |
| runs-on: ${{ matrix.os }} | |
| timeout-minutes: 180 | |
| steps: | |
| - name: Configure git CRLF settings | |
| run: | | |
| git config --global core.autocrlf false | |
| git config --global core.eol lf | |
| - uses: actions/checkout@v4 | |
| with: | |
| # We need to get all the git tags to make version injection work. See VERSION in Makefile for more detail. | |
| fetch-depth: 0 | |
| persist-credentials: false | |
| submodules: recursive | |
| - name: Set output variables | |
| id: vars | |
| run: | | |
| $has_creds="${{ github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name }}" | |
| echo "has_creds=$has_creds" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append | |
| exit 0 # if $has_creds is false, powershell will exit with code 1 and this step will fail | |
| - name: configure aws credentials | |
| uses: aws-actions/configure-aws-credentials@v4 | |
| if: env.has_creds == 'true' | |
| with: | |
| role-to-assume: ${{ secrets.ROLE }} | |
| role-session-name: credhelper-test | |
| aws-region: ${{ secrets.REGION }} | |
| - name: Remove Finch VM | |
| run: | | |
| Start-Process -NoNewWindow -FilePath wsl -ArgumentList '--install Ubuntu' | |
| wsl --list --verbose | |
| wsl --shutdown | |
| wsl --unregister lima-finch | |
| wsl --list --verbose | |
| - name: Clean up previous files | |
| run: | | |
| Remove-Item C:\Users\Administrator\.finch -Recurse -ErrorAction Ignore | |
| Remove-Item C:\Users\Administrator\AppData\Local\.finch -Recurse -ErrorAction Ignore | |
| make clean | |
| cd deps/finch-core && make clean | |
| - name: Build project | |
| run: | | |
| make | |
| - name: Run e2e tests | |
| run: | | |
| # set path to use newer ssh version | |
| $newPath = (";C:\Program Files\Git\bin\;" + "C:\Program Files\Git\usr\bin\;" + "$env:Path") | |
| $env:Path = $newPath | |
| git status | |
| git clean -f -d | |
| make test-e2e | |
| mdlint: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | |
| - uses: avto-dev/markdown-lint@04d43ee9191307b50935a753da3b775ab695eceb # v1.5.0 | |
| with: | |
| args: '**/*.md' | |
| # CHANGELOG.md is only updated by release-please bot. | |
| ignore: 'CHANGELOG.md' |