Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nex-droprate-calculator #6833

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Worley03
Copy link
Contributor

This plugin monitors the players contribution to Nex fights and continuously calculates the roll for a unique drop.

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 21, 2024

@LlemonDuck
Copy link
Contributor

NexDroprateCalculatorPanel is really annoying to review, you should use variables instead of casting repeatedly:

-    runPanel.add(new JLabel(labelTitle("- Current Kill -")));
-    ((JLabel) runPanel.getComponent(0)).setFont(font);
+    JLabel currentKillHeader = new JLabel("- Current Kill -");
+    currentKillHeader.setFont(font);
+    runPanel.add(currentKillHeader);

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 23, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 23, 2024
Worley03

This comment was marked as outdated.

@Worley03
Copy link
Contributor Author

No more repeat casting. Sorry I should of revised that section!

- Made Reset Averages Button update quicker while fight status is inactive.
- Fixed wrong method name. 
- Tweaked panel a bit
@LlemonDuck
Copy link
Contributor

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants