Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update random-hopper to v1.3 #6773

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Conversation

rugg0064
Copy link
Contributor

Update random-hopper to v1.3

  • Block hop commands during loading and hopping game states
  • Add persistent config

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 14, 2024

@YvesW
Copy link
Member

YvesW commented Oct 14, 2024

Not an extensive review, but could you remove the prints, or at least make them log.debug?

FYI you don't need to unset a configuration before setting it. Also, when a config key doesn't exist yet, getConfiguration will return null, but I assume you accounted for that.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 19, 2024
@rugg0064
Copy link
Contributor Author

rugg0064 commented Oct 19, 2024

Not an extensive review, but could you remove the prints, or at least make them log.debug?

I've removed the prints

FYI you don't need to unset a configuration before setting it. Also, when a config key doesn't exist yet, getConfiguration will return null, but I assume you accounted for that.

Addressed the configuration unset.

getConfiguration should be handled by the generic try catch, I think at least.

@iProdigy
Copy link
Member

random-hopper: plugin uses terminally deprecated APIs:
Use ComponentID or InterfaceID instead of WidgetInfo or WidgetID

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2024
@rugg0064 rugg0064 requested a review from a team as a code owner October 20, 2024 16:37
@runelite-github-app runelite-github-app bot added package change and removed waiting for author waiting for the pr author to make changes or respond to questions labels Oct 20, 2024
@YvesW
Copy link
Member

YvesW commented Oct 20, 2024

You're adding a binary file now.

@YvesW YvesW added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2024
@rugg0064
Copy link
Contributor Author

rugg0064 commented Oct 20, 2024

You're adding a binary file now.

😓 Apologies. I have no idea where that came from...

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 20, 2024
@LlemonDuck LlemonDuck merged commit 260871f into runelite:master Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants