-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random-hopper to v1.3 #6773
Conversation
Not an extensive review, but could you remove the prints, or at least make them log.debug? FYI you don't need to unset a configuration before setting it. Also, when a config key doesn't exist yet, getConfiguration will return null, but I assume you accounted for that. |
I've removed the prints
Addressed the configuration unset. getConfiguration should be handled by the generic try catch, I think at least. |
|
You're adding a binary file now. |
😓 Apologies. I have no idea where that came from... |
This reverts commit 99787a8.
Update random-hopper to v1.3