Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add persistent_disk_type variable #161

Merged
merged 1 commit into from
Aug 6, 2024
Merged

feat: add persistent_disk_type variable #161

merged 1 commit into from
Aug 6, 2024

Conversation

d-costa
Copy link
Collaborator

@d-costa d-costa commented Aug 6, 2024

what

  • Add variable to allow changing the type of the persistent disk

why

  • The module forces users to use pd-ssds

references

@d-costa d-costa requested a review from a team as a code owner August 6, 2024 13:45
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 6, 2024
bschaatsbergen
bschaatsbergen approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@d-costa d-costa merged commit 0adfb43 into runatlantis:main Aug 6, 2024
2 checks passed
@d-costa d-costa deleted the persistent_disk_type branch August 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support persistent_disk_type input in atlantis module
2 participants
@d-costa @bschaatsbergen