Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable terraform-docs push when on forks and sign commit #150

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

d-costa
Copy link
Collaborator

@d-costa d-costa commented Apr 19, 2024

what

  • Disable terraform-docs push when on forks
  • Use ghcommit-action to create a verified commit and push the changes, instead of using terraform-docs' git-push, which does not sign commits
  • Set continue-on-error to true since we only commit in the next step
  • Add instructions to run tfdocs locally for forks in workflow summary

why

references

@d-costa d-costa requested a review from a team as a code owner April 19, 2024 22:09
@github-actions github-actions bot added the github-actions Pull requests that update Github Actions code label Apr 19, 2024
@d-costa d-costa requested a review from calexandre April 19, 2024 22:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 19, 2024
@d-costa d-costa force-pushed the d-costa/tfdocs branch 8 times, most recently from ac93bc0 to e792768 Compare April 19, 2024 23:01
@d-costa d-costa changed the title Disable terraform-docs push when on forks and sign commit chore disable terraform-docs push when on forks and sign commit Apr 19, 2024
@d-costa d-costa changed the title chore disable terraform-docs push when on forks and sign commit chore: disable terraform-docs push when on forks and sign commit Apr 19, 2024
calexandre
calexandre previously approved these changes Apr 19, 2024
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 nice work @d-costa

@bschaatsbergen bschaatsbergen merged commit e4612c8 into main Apr 25, 2024
2 checks passed
@bschaatsbergen bschaatsbergen deleted the d-costa/tfdocs branch April 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github-actions Pull requests that update Github Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants