add temporary mincliversioncheck

frontend/src/apiTypes.d.ts

@@ -665,6 +665,11 @@ declare namespace ApiDef {
          * Date of build
          */
         build_date?: string; // date-time
+        /**
+         * The minimum version of skiver-cli that can be used with this server.
+         * The is [semver](https://semver.org/)-compatible, but has a leading `v`, like `v1.2.3`
+         */
+        cli_version_contraints?: string;
         /**
          * Size of database.
          */
@@ -684,11 +689,6 @@ declare namespace ApiDef {
         instance?: string;
         latest_cli_release?: ReleaseInfo;
         latest_release?: ReleaseInfo;
-        /**
-         * The minimum version of skiver-cli that can be used with this server.
-         * The is [semver](https://semver.org/)-compatible, but has a leading `v`, like `v1.2.3`
-         */
-        min_cli_version?: string;
         /**
          * When the server was started
          */

handlers/apiHandler.go

@@ -46,8 +46,11 @@ func EndpointsHandler(
 ) http.HandlerFunc {
 
 	return func(rw http.ResponseWriter, r *http.Request) {
-		if r.Method == http.MethodDelete {
-			return
+		switch r.Method {
+		case http.MethodPost, http.MethodDelete, http.MethodPut, http.MethodPatch:
+			if err := ValidateClientVersion(rw, r); err != nil {
+				return
+			}
 		}
 		AddAccessControl(r, rw)
 

handlers/getClientVersion.go

@@ -0,0 +1,71 @@
+package handlers
+
+import (
+	"encoding/json"
+	"fmt"
+	"net/http"
+
+	"github.com/Masterminds/semver/v3"
+	"github.com/runar-rkmedia/skiver/utils"
+)
+
+type CallingClient struct {
+	Name    string
+	Version string
+	GitHash string
+	Semver  *semver.Version
+}
+
+func GetClientVersionFromRequest(r *http.Request) (client CallingClient, found bool) {
+	client.Name = r.Header.Get("Client_App")
+	found = client.Name != ""
+	client.GitHash = r.Header.Get("Client_Hash")
+	client.Version = r.Header.Get("Client_version")
+	if client.Version != "" {
+		if v, err := semver.NewVersion(client.Version); err == nil {
+			client.Semver = v
+		}
+	}
+
+	return
+}
+
+var mincliversion = utils.Must(semver.NewConstraint(">= 0.6.0"))
+
+// temporary check for clients before they upgrade to a version of
+func ValidateClientVersion(rw http.ResponseWriter, r *http.Request) error {
+	client, found := GetClientVersionFromRequest(r)
+	if !found {
+		// a client which is not reporting their versioning.
+		// we have not control over them, and do not wish to interfere
+		return nil
+	}
+	// This is temporary
+	var err error
+	var details []any
+	if client.Version == "" {
+		err = fmt.Errorf("client %s detected, missing version-number. Please upgrade.", client.Name)
+	} else if client.Semver == nil {
+		err = fmt.Errorf("client %s with version '%s' is outdated. Please upgrade", client.Name, client.Version)
+	} else {
+		switch client.Name {
+		case "skiver-cli":
+			if ok, errs := mincliversion.Validate(client.Semver); !ok {
+				err = fmt.Errorf("client '%s' with version '%s' (%s) is outdated. Please upgrade", client.Name, client.Version, client.Semver.String())
+				details = append(details, errs)
+			}
+
+		}
+	}
+	if err == nil {
+		return nil
+	}
+	json, jerr := json.Marshal(NewApiErr(err, http.StatusConflict, "ErrOutdatedClient", details...))
+	if jerr != nil {
+		panic(err)
+	}
+	rw.Header().Set("Content-Type", "application/json")
+	rw.WriteHeader(http.StatusConflict)
+	rw.Write([]byte(json))
+	return err
+}

main.go

@@ -602,13 +602,13 @@ func main() {
 		sync.RWMutex
 	}{
 		types.ServerInfo{
-			ServerStartedAt: serverStartTime,
-			GitHash:         commit,
-			Version:         version,
-			BuildDate:       buildDate,
-			MinCliVersion:   "v0.6.0",
-			Instance:        getInstanceHash(),
-			HostHash:        gethostNameHash(),
+			ServerStartedAt:       serverStartTime,
+			GitHash:               commit,
+			Version:               version,
+			BuildDate:             buildDate,
+			CliVersionConstraints: ">=v0.6.0",
+			Instance:              getInstanceHash(),
+			HostHash:              gethostNameHash(),
 		},
 		sync.RWMutex{},
 	}
@@ -802,6 +802,13 @@ func main() {
 		return func(rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
 			startTime := time.Now()
 			debug := l.HasDebug()
+			switch r.Method {
+
+			case http.MethodPost, http.MethodDelete, http.MethodPut, http.MethodPatch:
+				if err := handlers.ValidateClientVersion(rw, r); err != nil {
+					return
+				}
+			}
 			var err error
 			defer func() {
 				since := time.Since(startTime)
@@ -972,12 +979,13 @@ func main() {
 			return nil
 		}}))
 	router.GET("/api/translation/", pipeline("GetTranslation", handlers.GetTranslations()))
-	router.GET("/api/serverInfo/", pipeline("GetServerInfo", handlers.GetServerInfo(&db, func() *types.ServerInfo {
+	serverInfoRetriever := func() *types.ServerInfo {
 		info.RLock()
 		defer info.RUnlock()
 		return &info.ServerInfo
 
-	})))
+	}
+	router.GET("/api/serverInfo/", pipeline("GetServerInfo", handlers.GetServerInfo(&db, serverInfoRetriever)))
 	router.POST("/api/project/snapshot/", pipeline("PostSnapshot", handlers.PostSnapshot(uploaders), routeOptions{sessionRole: func(s types.Session, _ *http.Request) error {
 		if !s.User.CanUpdateProjects {
 			return fmt.Errorf("You are not authorized to create snapshots")

swagger.yml

@@ -1159,6 +1159,12 @@ definitions:
         format: date-time
         type: string
         x-go-name: BuildDate
+      cli_version_contraints:
+        description: |-
+          The minimum version of skiver-cli that can be used with this server.
+          The is [semver](https://semver.org/)-compatible, but has a leading `v`, like `v1.2.3`
+        type: string
+        x-go-name: CliVersionConstraints
       database_size:
         description: Size of database.
         format: int64
@@ -1183,12 +1189,6 @@ definitions:
         $ref: '#/definitions/ReleaseInfo'
       latest_release:
         $ref: '#/definitions/ReleaseInfo'
-      min_cli_version:
-        description: |-
-          The minimum version of skiver-cli that can be used with this server.
-          The is [semver](https://semver.org/)-compatible, but has a leading `v`, like `v1.2.3`
-        type: string
-        x-go-name: MinCliVersion
       server_started_at:
         description: When the server was started
         format: date-time

types/serverInfo.go

@@ -30,7 +30,7 @@ type ServerInfo struct {
 	LatestReleaseCLI *ReleaseInfo `json:"latest_cli_release"`
 	// The minimum version of skiver-cli that can be used with this server.
 	// The is [semver](https://semver.org/)-compatible, but has a leading `v`, like `v1.2.3`
-	MinCliVersion string `json:"min_cli_version"`
+	CliVersionConstraints string `json:"cli_version_contraints,omitempty"`
 }
 
 // Server info

utils/must.go

@@ -0,0 +1,11 @@
+package utils
+
+// unwraps the first value, panics if err
+func Must[T any](t T, err error) T {
+
+	if err != nil {
+		panic(err)
+	}
+	return t
+
+}