feat: Add Dockerfile template #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RUN npm run build | ||
|
|
||
| # ==================================== | ||
| FROM build as release |
There was a problem hiding this comment.
looks to me like the release image doesn't have any files (no COPY command) - how does this work?
There was a problem hiding this comment.
It's already copied in the build stage. We just use everything from the build stage to the release for now.
There was a problem hiding this comment.
ah i see, should be FROM node20 as release and then copy just the build files
leehuwuj
force-pushed
the
lee/add-dockers
branch
from
445c1ec
to
81d1b1d
Compare
marcusschiesser
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.