refactor: make non-streaming chat as /chat/request route #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/types/streaming/express/src/controllers/chat.middleware.ts
Outdated
Show resolved
Hide resolved
|
|
||
| ``` | ||
| curl --location 'localhost:8000/api/chat/request' \ | ||
| --header 'Content-Type: text/plain' \ |
There was a problem hiding this comment.
@thucpn we don't support application/json?
There was a problem hiding this comment.
It should be application/json
questions.ts
Outdated
| @@ -370,7 +370,6 @@ export const askQuestions = async ( | |||
| name: "template", | |||
| message: "Which template would you like to use?", | |||
| choices: [ | |||
| { title: "Chat without streaming", value: "simple" }, | |||
| { title: "Chat with streaming", value: "streaming" }, | |||
There was a problem hiding this comment.
Suggested change
| { title: "Chat with streaming", value: "streaming" }, | |
| { title: "Chat", value: "streaming" }, |
| result: _Message | ||
|
|
||
|
|
||
| async def preprocess_request(data: _ChatData) -> tuple: |
There was a problem hiding this comment.
Suggested change
| async def preprocess_request(data: _ChatData) -> tuple: | |
| from typing import List, Tuple | |
| # parses _ChatData to be used by LlamaIndex chat | |
| async def parse_chat_data(data: _ChatData) -> Tuple[str, List[ChatMessage]]: |
| @@ -44,16 +42,36 @@ async def chat( | |||
| ) | |||
| for m in data.messages | |||
| ] | |||
| return last_message, messages | |||
There was a problem hiding this comment.
Here we're a bit in a pickle as last_message is a different message type than messages, to be consistent we could either return:
Suggested change
| return last_message, messages | |
| return last_message.content, messages |
or
Suggested change
| return last_message, messages | |
| return ChatMessage(role=last_message.role, | |
| content=last_message.content), messages |
I think the first one is easier to understand
thucpn
force-pushed
the
refactor/remove-simple-chat
branch
from
61871fb
to
e5137d2
Compare
marcusschiesser
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.