Skip to content

Commit

Permalink
fix: fix windows e2e (#13)
Browse files Browse the repository at this point in the history
  • Loading branch information
thucpn authored Mar 21, 2024
1 parent abb7488 commit 56faee0
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/chatty-toes-retire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-llama": patch
---

Add windows e2e tests
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
matrix:
node-version: [18, 20]
python-version: ["3.11"]
os: [macos-latest] #, windows-latest]
os: [macos-latest, windows-latest]
defaults:
run:
shell: bash
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
run: pnpm run build
working-directory: .
- name: Install
run: pnpm run install-local
run: pnpm run pack-install
working-directory: .
- name: Run Playwright tests
run: pnpm run e2e
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,6 @@ e2e/cache

# intellij
**/.idea

# build artifacts
create-llama-*.tgz
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ To install it, call:
pnpm exec playwright install --with-deps
```

Then you can first install the `create-llama` command locally:
Then you can create a global `create-llama` command (used by the e2e tests) that is linked to your local dev environment (if you update the build, you don't need to re-link):

```
pnpm run install-local
pnpm link --global
```

And then finally run the tests:
Expand Down
1 change: 0 additions & 1 deletion index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env node
/* eslint-disable import/no-extraneous-dependencies */
import { execSync } from "child_process";
import Commander from "commander";
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@
"format": "prettier --ignore-unknown --cache --check .",
"format:write": "prettier --ignore-unknown --write .",
"dev": "ncc build ./index.ts -w -o dist/",
"build": "npm run clean && ncc build ./index.ts -o ./dist/ --minify --no-cache --no-source-map-register",
"build": "bash ./scripts/build.sh",
"lint": "eslint . --ignore-pattern dist --ignore-pattern e2e/cache",
"e2e": "playwright test",
"prepare": "husky",
"install-local": "pnpm link --global",
"release": "pnpm run build && changeset publish",
"new-version": "pnpm run build && changeset version",
"release-snapshot": "pnpm run build && changeset publish --tag snapshot",
"new-snapshot": "pnpm run build && changeset version --snapshot"
"new-snapshot": "pnpm run build && changeset version --snapshot",
"pack-install": "bash ./scripts/pack.sh"
},
"devDependencies": {
"@playwright/test": "^1.41.1",
Expand Down
7 changes: 7 additions & 0 deletions scripts/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env bash

# build dist/index.js file
npm run clean && ncc build ./index.ts -o ./dist/ --minify --no-cache --no-source-map-register

# add shebang to the top of dist/index.js (space after shebang is to fix windows issue)
echo '#!/usr/bin/env node ' | cat - dist/index.js > temp && mv temp dist/index.js
3 changes: 3 additions & 0 deletions scripts/pack.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

pnpm pack && npm install -g $(pwd)/$(ls ./*.tgz | head -1)

0 comments on commit 56faee0

Please sign in to comment.