Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #109

Merged
merged 1 commit into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import { camalize } from './utils.js'
import config from '@aws-sdk/shared-ini-file-loader';
import config from '@smithy/shared-ini-file-loader';

/**
* Process config using the following order:
Expand Down
6 changes: 3 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import { format as formatOutput } from './formatter.js';
import { hideBin } from 'yargs/helpers';
import { join } from 'node:path';
import { spawn } from 'node:child_process';
import { openApp } from 'open';
import envpaths from 'env-paths';
import open from 'open';
import playwright from 'playwright';
import prompts from 'prompts';
import trash from 'trash';
Expand Down Expand Up @@ -88,7 +88,7 @@ const credentialsManager = new CredentialsManager(logger, argv.awsRegion, argv['
if (argv._[0] === 'console') {
logger.debug('Opening url %s', SAML_URL);

return await open(SAML_URL);
return await openApp(SAML_URL);
}

if (argv.clean) {
Expand Down Expand Up @@ -281,7 +281,7 @@ const credentialsManager = new CredentialsManager(logger, argv.awsRegion, argv['
} catch (e) {
// The request to the AWS console is aborted on successful login for performance reasons,
// so in this particular case closing the browser instance is actually an expected outcome.
if (/browser has disconnected/.test(e.message) || /Navigation failed because page was closed/.test(e.message)) {
if (/browser has disconnected/.test(e.message) || /browser has been closed/.test(e.message) || /Navigation failed because page was closed/.test(e.message)) {
return;
}

Expand Down
Loading
Loading