text: Fix selection background rendering #18437
Merged
+581
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
kjarosh
force-pushed
the
text-selection
branch
from
bfef421
to
b1dff54
Compare
Dinnerbone
approved these changes
Nov 15, 2024
This is helpful for situations where we want x-axis positions only.
This makes render_layout_box smaller and makes it possible to use it outside of this function.
This refactor makes it possible to iterate over vvisible lines multiple times in other places.
Flash Player renders the black selection rectangles in the background, and takes into consideration line bounds and conditionally its leading.
This test verifies how the text selection is rendered for various values of leading.
This test verifies how FP renders selection when there are multiple font sizes in one line.
Dinnerbone
force-pushed
the
text-selection
branch
from
b1dff54
to
0afb7e3
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR most importantly fixes the following problems:
However, this does not fix the problem of selected text not being always rendered over anything else. There's
max_outliersadded due to that in some images. Also it does not take into account differences resulting from using device fonts (there are some).Fixes #14713.