core: Improve ergonomics by replacing GcContext by StringContext
#18105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-core
moulins
force-pushed
the
string-context
branch
from
05c56d5
to
ab2d88c
Compare
Lord-McSweeney
approved these changes
Sep 30, 2024
moulins
force-pushed
the
string-context
branch
from
ab2d88c
to
db97143
Compare
evilpie
force-pushed
the
string-context
branch
from
db97143
to
01bcb18
Compare
This is essentially still the same type, but with these differences: - It is explicitely intended to be used for `AvmString` manipulation - It is held inside `UpdateContext` instead of being created on-demand, making explicit 'reborrowing' methods unncessary. Note the `unsafe` lifetime extension in `PlayerBuilder::create_gc_root`, which is sound for mostly the same reasons as `Player::enter_arena(_mut)`
This makes usage much simpler: `context.intern(...)` instead of `context.interner.intern(context.gc(), ...)`. Also make `StringContext.interner` private, as it doesn't need to be publicly accessible anymore.
- Rename `get_char` to `make_char`, and `get_ascii_char` to `ascii_char`: this makes clearer that only `make_char` may allocate. - Take a `u8` instead of a `char` in `ascii_char`. - Take a `Range<usize>` instead of two `usize` args in `substring`.
moulins
force-pushed
the
string-context
branch
from
01bcb18
to
357c9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #18081.
Embeds a
&Mutation<'gc>directly into the string interner context (which is renamed fromGcContexttoStringContext, for clarity), and makes it accessible inUpdateContextwithout the need for an explicit reborrow method.This simplifies most usages, as we don't need to pass a
&Mutation<'gc>separately.