-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: Internationalize metainfo and desktop file #18091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-desktop
Area: Desktop Application
linux
T-feature
Type: New Feature (that Flash doesn't have)
waiting-on-review
Waiting on review from a Ruffle team member
labels
Sep 27, 2024
Dinnerbone
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm mostly trusting that you know this stuff :D
In order to make this file translatable, we have to store its source (as an .in file), and the original path will store its final version.
In order to make this file translatable, we have to store its source (as an .in file), and the original path will store its final version.
The added Makefile may be used to easily generate PO templates for translation and apply PO translations to the final metainfo and desktop file.
Those files do not include translations, they will be overridden by Crowdin when syncing translations.
torokati44
reviewed
Oct 1, 2024
torokati44
reviewed
Oct 1, 2024
danielhjacobs
removed
the
waiting-on-review
Waiting on review from a Ruffle team member
label
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea behind translation of metainfo and desktop file:
.in
versions of these files without any translations..pot
) files from.in
..po
files from Crowdin..in
), but do not commit them..in
).