Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch egui back to release 0.29.0 from git #18082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ tracing = "0.1.40"
tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
naga = { version = "22.1.0", features = ["wgsl-out"] }
wgpu = "22.1.0"
egui = { git = "https://github.com/emilk/egui.git", rev = "06f709481a4e5e74bec961544c77e9afcae265db" }
egui = "0.29.0"
clap = { version = "4.5.18", features = ["derive"] }
cpal = "0.15.3"
anyhow = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ hashbrown = { version = "0.14.5", features = ["raw"] }
scopeguard = "1.2.0"
fluent-templates = "0.11.0"
egui = { workspace = true, optional = true }
egui_extras = { git = "https://github.com/emilk/egui.git", rev = "06f709481a4e5e74bec961544c77e9afcae265db", default-features = false, optional = true }
egui_extras = { version = "0.29.0", default-features = false, optional = true }
png = { version = "0.17.13", optional = true }
flv-rs = { path = "../flv" }
async-channel = { workspace = true }
Expand Down
4 changes: 1 addition & 3 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,9 @@ unknown-registry = "deny"
unknown-git = "deny"

[sources.allow-org]
# github.com organizations to allow git sources for
# github.com organizations to allow git sources for
github = [
"ruffle-rs",
# TODO: Remove once a release with https://github.com/emilk/egui/pull/4939 in it is out.
"emilk",
]

[advisories]
Expand Down
6 changes: 3 additions & 3 deletions desktop/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ workspace = true
clap = { workspace = true }
cpal = { workspace = true }
egui = { workspace = true }
egui_extras = { git = "https://github.com/emilk/egui.git", rev = "06f709481a4e5e74bec961544c77e9afcae265db", default-features = false, features = ["image"] }
egui-wgpu = { git = "https://github.com/emilk/egui.git", rev = "06f709481a4e5e74bec961544c77e9afcae265db", features = ["winit"] }
egui_extras = { version = "0.29.0", default-features = false, features = ["image"] }
egui-wgpu = { version = "0.29.0", features = ["winit"] }
image = { workspace = true, features = ["png"] }
egui-winit = { git = "https://github.com/emilk/egui.git", rev = "06f709481a4e5e74bec961544c77e9afcae265db" }
egui-winit = "0.29.0"
fontdb = "0.22"
ruffle_core = { path = "../core", features = ["audio", "clap", "mp3", "nellymoser", "default_compatibility_rules", "egui"] }
ruffle_render = { path = "../render", features = ["clap"] }
Expand Down
26 changes: 14 additions & 12 deletions desktop/src/gui/controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,18 +353,20 @@ impl GuiController {
{
let surface_view = surface_texture.texture.create_view(&Default::default());

let mut render_pass = encoder.begin_render_pass(&wgpu::RenderPassDescriptor {
color_attachments: &[Some(wgpu::RenderPassColorAttachment {
view: &surface_view,
resolve_target: None,
ops: wgpu::Operations {
load: wgpu::LoadOp::Clear(wgpu::Color::BLACK),
store: wgpu::StoreOp::Store,
},
})],
label: Some("egui_render"),
..Default::default()
});
let mut render_pass = encoder
.begin_render_pass(&wgpu::RenderPassDescriptor {
color_attachments: &[Some(wgpu::RenderPassColorAttachment {
view: &surface_view,
resolve_target: None,
ops: wgpu::Operations {
load: wgpu::LoadOp::Clear(wgpu::Color::BLACK),
store: wgpu::StoreOp::Store,
},
})],
label: Some("egui_render"),
..Default::default()
})
.forget_lifetime();

if let Some(movie_view) = movie_view {
movie_view.render(&self.movie_view_renderer, &mut render_pass);
Expand Down
8 changes: 4 additions & 4 deletions desktop/src/gui/movie.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ impl MovieView {
}
}

pub fn render<'pass, 'global: 'pass>(
&'pass self,
renderer: &'global MovieViewRenderer,
render_pass: &mut wgpu::RenderPass<'pass>,
pub fn render(
&self,
renderer: &MovieViewRenderer,
render_pass: &mut wgpu::RenderPass<'static>,
) {
render_pass.set_pipeline(&renderer.pipeline);
render_pass.set_bind_group(0, &self.bind_group, &[]);
Expand Down