core: Fix "Failed to get Object" panics #18046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
added
A-core
torokati44
reviewed
Sep 24, 2024
torokati44
reviewed
Sep 24, 2024
torokati44
force-pushed
the
amf_fixes
branch
from
ff75f1e
to
dc59d83
Compare
|
Since the act of merging ruffle-rs/rust-flash-lso#68 changed its HEAD hash (and there were some changes added to it even before the merge), I amended this branch accordingly. While at it, I also squashed a few "fixup" type commits into the original commits they fix, for cleaner commit history. I hope you don't mind, @CUB3D. |
torokati44
reviewed
Oct 2, 2024
torokati44
approved these changes
Oct 2, 2024
Dinnerbone
approved these changes
Oct 3, 2024
Lord-McSweeney
approved these changes
Oct 5, 2024
torokati44
reviewed
Oct 10, 2024
core/src/avm2/array.rs
Outdated
| @@ -114,6 +114,25 @@ impl<'gc> ArrayStorage<'gc> { | |||
| } | |||
| } | |||
|
|
|||
| /// Replace the existing dense storage with a new dense storage | |||
| /// Does nothing if this `ArrayStorage` is sparse | |||
There was a problem hiding this comment.
This comment is now outdated due to the added panic!.
I'm just gonna fix this and merge.
Thank you!
There was a problem hiding this comment.
... also squashed this last "chore" commit into the first one.
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constitues the ruffle-side changes of ruffle-rs/rust-flash-lso#67 and ruffle-rs/rust-flash-lso#68.
This fixes the following (previously would panic on load):
#17902 - loads
#17709 - loads
#13748 - loads
#10520 - loads
This prevents panics on the following:
#17782 - (and possible dupe #17336 )
Now errors with "Property uploadFromBitmapData not found on flash.display3D.textures.RectangleTexture and there is no default value."
#14329
Fails to load past 54%, some URL load failures might be related
#10174
Same as 17782 above
These are not fixed, but one possible underlying issue is that a new
AMF3Decoderis created for each call toByteArray.readObjectwhich could result in missing references that are replaced withUndefinedwhen an element references a prior value in the stream. In the simple case, we could just cache theAMF3Decoderin theByteArrayobject, but this won't handle more complex cases where theByteArrays position is changed, so I'm leaving this for future work.Update: I'm actually unsure if the above guess is true anymore, a missing change progressed the above and removed the invalid reference warnings but it still seems odd.