avm2: Add AIR Screen API #17608
Open
avm2: Add AIR Screen API #17608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private var _width:int; | ||
| private var _height:int; | ||
|
|
||
| [API(661)] |
There was a problem hiding this comment.
I don't think this needs a versioning, since the entire Screen class is already versioned
| return bounds; | ||
| } | ||
|
|
||
| [API(661)] |
| import flash.geom.Rectangle; | ||
|
|
||
| // [API("733")] Ruffle doesn't support this API Version | ||
| [API(661)] |
There was a problem hiding this comment.
Can this put the versioning in quotes like [API("661")] for consistency with other versioning metadata?
kjarosh
reviewed
Aug 31, 2024
| @@ -211,6 +211,10 @@ impl UiBackend for WebUiBackend { | |||
| self.update_mouse_cursor(); | |||
| } | |||
|
|
|||
| fn get_screens_sizes(&self) -> Vec<(u32, u32)> { | |||
| vec![(self.canvas.width(), self.canvas.height())] | |||
There was a problem hiding this comment.
What about window.screen.width/window.screen.height? https://developer.mozilla.org/en-US/docs/Web/API/Screen/width
kjarosh
reviewed
Aug 31, 2024
| @@ -344,6 +348,10 @@ impl UiBackend for NullUiBackend { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn get_screens_sizes(&self) -> Vec<(u32, u32)> { | |||
There was a problem hiding this comment.
Suggested change
| fn get_screens_sizes(&self) -> Vec<(u32, u32)> { | |
| fn get_screen_sizes(&self) -> Vec<(u32, u32)> { |
kjarosh
reviewed
Aug 31, 2024
| return screens[0]; | ||
| } | ||
|
|
||
| public static native function getScreensInternal():Array; |
There was a problem hiding this comment.
- I believe this method shouldn't be public.
- Currently this method is being executed at most once, but the screen configuration may change in time. I'd go with making all methods native and reading always the most recent info (assuming it's what AIR does).
kjarosh
added
the
waiting-on-author
Fancy2209
force-pushed
the
air-screen
branch
from
e63bb60
to
b48003a
Compare
danielhjacobs
added
A-avm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.