avm2: Declare correct signature for builtin rust-side getters/setters #17494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
changed the title
torokati44
force-pushed
the
builtin-getter-settter-types
branch
from
7dc3e56
to
06ac6fc
Compare
|
This should be even simpler after #17792 lands. |
evilpie
added
the
waiting-on-author
danielhjacobs
added
A-avm2
Aaron1011
force-pushed
the
builtin-getter-settter-types
branch
from
06ac6fc
to
a274833
Compare
This only affects the handful of classes that we still implement entirely in Rust (with only an ActionScript stub when compiling playerglobals). We now expose the proper signatures to `describeType`, and have more type information for future use in the optimizer.
Aaron1011
force-pushed
the
builtin-getter-settter-types
branch
from
a274833
to
8e310c7
Compare
Aaron1011
removed
the
waiting-on-author
evilpie
reviewed
Sep 26, 2024
| @@ -1155,24 +1156,39 @@ impl<'gc> Class<'gc> { | |||
| &'static str, | |||
| Option<NativeMethodImpl>, | |||
| Option<NativeMethodImpl>, | |||
| Option<Gc<'gc, Multiname<'gc>>>, | |||
There was a problem hiding this comment.
Wouldn't it be simpler if this accepted Option<&' static str> instead?
There was a problem hiding this comment.
I think the simplest thing here would be to use the CommonNamespaces fields in the getter/setter definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects the handful of classes that we still implement entirely in Rust (with only an ActionScript stub when compiling playerglobals).
We now expose the proper signatures to
describeType, and have more type information for future use in the optimizer.