desktop: Fix Ruffle not responding when picking a file #17413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
file-picker-async
branch
from
d2b4851
to
fad8c4c
Compare
|
So, having an async runtime (tokio) did end up coming in handy after all? (: |
torokati44
force-pushed
the
file-picker-async
branch
from
fad8c4c
to
21c8f7d
Compare
kjarosh
force-pushed
the
file-picker-async
branch
from
21c8f7d
to
99566f8
Compare
This allows modifying it asynchronously.
This patch fixes the problem of Ruffle not responding when picking a file.
kjarosh
force-pushed
the
file-picker-async
branch
from
99566f8
to
b92dfde
Compare
torokati44
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
I think @danielhjacobs tested this on Windows, and found no issues without the workaround.
|
Yeah, the issue doesn't exist without the workaround anymore even without this PR. |
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11336.
This PR fixes the problem of Ruffle not responding when picking a file.
This needs to be tested on Windows before merge, because I removed a Windows-specific workaround hoping that it won't be needed when picking files asynchronously.rust-windowing/winit#2291 (comment)