web,video: Add H264 decoding using the WebCodecs API #16794
+345
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
external-video-webcodecs
branch
5 times, most recently
from
65c01d8
to
e9c744b
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
from
e9c744b
to
877b6b1
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
5 times, most recently
from
816e327
to
c96c40c
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
from
c96c40c
to
43a992c
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
4 times, most recently
from
9afffe8
to
d40c036
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
2 times, most recently
from
c47534e
to
f3bd05b
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
2 times, most recently
from
35cf89c
to
bf5c71c
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
2 times, most recently
from
74cf97b
to
cf85e0f
Compare
|
Rebased on top of #17878. |
torokati44
force-pushed
the
external-video-webcodecs
branch
from
cf85e0f
to
033a7c7
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
from
033a7c7
to
f4edc57
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
2 times, most recently
from
98302d1
to
d45c3de
Compare
torokati44
force-pushed
the
external-video-webcodecs
branch
5 times, most recently
from
9250fe2
to
8132286
Compare
torokati44
added
the
waiting-on-review
torokati44
force-pushed
the
external-video-webcodecs
branch
from
8132286
to
c6a19de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #14654.
Not really done yet, just pushing for visibility, and so that it doesn't get forgotten.
(Just look at the commit history lol.)Due to this API being based on callbacks, this currently adds at least one additional (video) frame of delay as compared to a synchronous decoder, such as OpenH264 on desktop. I think this should be acceptable.
It would be possible to wire the callback straight from the browser through the video backend to the renderer backend, to update the texture immediately (off the regular frame pacing schedule), but I think that would be a bit too complicated, and could potentially result in less smooth playback.
Mostly works, in Chrome and in Firefox 129+.
I don't think this could be problematic at all from a patents/licensing/royalty standpoint.
Advances #8891.