Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
  • Loading branch information
bperseghetti and ahcorde authored May 16, 2024
1 parent e0709df commit 9c2474f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions include/sdf/Cone.hh
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ namespace sdf

/// \brief Set the cone's radius in meters.
/// \param[in] _radius The radius of the cone in meters.
public: void SetRadius(const double _radius);
public: void SetRadius(double _radius);

/// \brief Get the cone's length in meters.
/// \return The length of the cone in meters.
public: double Length() const;

/// \brief Set the cone's length in meters.
/// \param[in] _length The length of the cone in meters.
public: void SetLength(const double _length);
public: void SetLength(double _length);

/// \brief Get a pointer to the SDF element that was used during
/// load.
Expand Down
5 changes: 3 additions & 2 deletions src/Cone.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <optional>

#include <gz/math/Inertial.hh>
#include <gz/math/Cone.hh>
#include "sdf/Cone.hh"
#include "sdf/parser.hh"
#include "Utils.hh"
Expand Down Expand Up @@ -107,7 +108,7 @@ double Cone::Radius() const
}

//////////////////////////////////////////////////
void Cone::SetRadius(const double _radius)
void Cone::SetRadius(double _radius)
{
this->dataPtr->cone.SetRadius(_radius);
}
Expand All @@ -119,7 +120,7 @@ double Cone::Length() const
}

//////////////////////////////////////////////////
void Cone::SetLength(const double _length)
void Cone::SetLength(double _length)
{
this->dataPtr->cone.SetLength(_length);
}
Expand Down

0 comments on commit 9c2474f

Please sign in to comment.