Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
  • Loading branch information
bperseghetti and ahcorde committed May 20, 2024
1 parent 7ab3d56 commit 341727d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/Cone.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
* limitations under the License.
*
*/
#include <sstream>
#include <optional>
#include <sstream>
#include <utility>

#include <gz/math/Inertial.hh>
#include <gz/math/Cone.hh>
Expand Down
2 changes: 1 addition & 1 deletion src/Cone_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ TEST(DOMCone, CalculateInertial)
cone.SetRadius(r);

double expectedMass = cone.Shape().Volume() * density;
double ixxIyy = (3/80.0) * expectedMass * (4*r*r + l*l);
double ixxIyy = (3 / 80.0) * expectedMass * (4 * r * r + l * l);
double izz = 3.0 * expectedMass * r * r / 10.0;

gz::math::MassMatrix3d expectedMassMat(
Expand Down
2 changes: 1 addition & 1 deletion src/Geometry_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ TEST(DOMGeometry, CalculateInertial)
cone.SetRadius(r);

expectedMass = cone.Shape().Volume() * density;
double ixxIyy = (3/80.0) * expectedMass * (4*r*r + l*l);
double ixxIyy = (3 / 80.0) * expectedMass * (4 * r * r + l * l);
double izz = 3.0 * expectedMass * r * r / 10.0;

expectedMassMat.SetMass(expectedMass);
Expand Down

0 comments on commit 341727d

Please sign in to comment.