Fixed proxy ticket #202
Open
Fixed proxy ticket #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceTicket.find_by_ticket returns null if the ticket is a ProxyTicket, due to ActiveRecord class name filtering. Changed to SPTicket.
ProxyTicket uses granted_by_tgt as well, moved to parent class SPTicket.
Pgt was being destroyed by username at logout causing non-valid pgts if the user was connected on other devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that PT-* tickets are not recognised by the server since the query is fired from ServiceTicket model, triggering ActiveRecord filter on class name (as result, only the tickets with ServiceTicket class are selected).
The field is present on the db and it works fine when using SPTicket find_by_ticket method.
Also, granted_by_tgt is called in server.rb (proxyValidate), but this is missing in ProxyTicket model declaration.