Add Alpine Linux as supported platform #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Dec 17, 2023
There was a problem hiding this comment.
Could you also add Alpine Linux to CI?
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 2bef357..711740e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -10,6 +10,7 @@ jobs:
matrix:
distribution:
- almalinux-9
+ - alpine-linux
- alt-linux
- amazon-linux-2
- amazon-linux-2023| @@ -0,0 +1,41 @@ | |||
| # Copyright (C) 2017-2023 Ruby-GNOME Project Team | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2017-2023 Ruby-GNOME Project Team | |
| # Copyright (C) 2023 Ruby-GNOME Project Team |
| @@ -46,6 +46,7 @@ def detect | |||
|
|
|||
| require_relative "platform/debian" | |||
| require_relative "platform/ubuntu" | |||
| require_relative "platform/alpine-linux" | |||
There was a problem hiding this comment.
These require_relatives are for Debian based distributions.
Could you put this after platform/suse?
diff --git a/lib/native-package-installer/platform.rb b/lib/native-package-installer/platform.rb
index 8476fbd..528c785 100644
--- a/lib/native-package-installer/platform.rb
+++ b/lib/native-package-installer/platform.rb
@@ -57,6 +57,8 @@ require_relative "platform/amazon-linux-2023"
require_relative "platform/suse"
+require_relative "platform/alpine-linux"
+
# Windows
require_relative "platform/msys2"
Watson1978
force-pushed
the
alpine-linux
branch
from
d4f1025
to
451266b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add Alpine Linux as supported platform.