Add Rails/EnumKeywordArgs cop

[maxprokopiev]

This PR adds a new cop called Rails/EnumKeywordArgs.

This cop checks for the use of deprecated keyword arguments in enums. See more in #1238

Style guide PR: rubocop/rails-style-guide#356

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
• If this is a new cop, consider making a corresponding update to the Rails Style Guide.

[maxprokopiev]

see rubocop/rails-style-guide#356 (comment)

[ghiculescu]

see rubocop/rails-style-guide#356 (comment)

A linter would still be helpful if it helps people autocorrect so they can migrate to the new API automatically.

[maxprokopiev]

reopening this one since there seem to be some demand to have a linter, but not an entry to the style guide

[fatkodima]

Rails 7.2 is about to be released (there is a stable branch already https://github.com/rails/rails/tree/7-2-stable).

@koic Can you please consider this PR?

[chaadow]

@maxprokopiev Hi, btw i've used your branch to upgrade a legacy rails app that uses this old format of keyword args. your implementation detected pretty much all my cases except these 2 cases :

`-

SOME_HASH_CONSTANT = { 0: 'active', 1: 'inactive }

enum my_enum: SOME_HASH_CONSTANT

==> the cop does not detect this at all. But since I have deprecations raise in development, i was able to eager load ( by calling bin/rails zeitwerk:check and find these edge cases.

2- Second point i noticed, the autocorrection is not available for _suffix and _prefix

# Here the hash is correct, your cop detects the use of "undierscore
# but the autocorrection is not available to change `_suffix` to `suffix
enum :my_enum,  { 0: 'active', 1: 'inactive }, _suffix: true

for my case, i think it was : enum :my_enum, SOME_HASH_CONSTANT, _suffix: true

[ohbarye]

Now that Rails 7.2.0 has been released, I hope this pull request moves forward for a smooth upgrade. 👍

https://rubyonrails.org/2024/8/10/Rails-7-2-0-has-been-released

[koic]

How about the name Rails/EnumSyntax?

Suggested change

	class EnumKeywordArgs < Base
	class EnumSyntax < Base

[koic]

Suggested change

	# and will be removed in Rails 7.3.
	# and will be removed in Rails 8.0.

[koic]

Can you add the Severity: warning setting:

Suggested change

	Enabled: pending
	VersionAdded: '<<next>>'
	Enabled: pending
	Severity: warning
	VersionAdded: '<<next>>'

[koic]

I think that it has been supported since Rails 5.0:

Suggested change

	extend AutoCorrector
	extend AutoCorrector
	extend TargetRailsVersion
	minimum_target_rails_version 5.0

[koic]

Can you remove it because it follows a different style guide rule?

Suggested change

StyleGuide: 'https://rails.rubystyle.guide#enums'

[koic]

Suggested change

	* [#1239](https://github.com/rubocop/rubocop-rails/pull/1239): Add new `Rails/EnumKeywordArgs`. ([@maxprokopiev][])
	* [#1238](https://github.com/rubocop/rubocop-rails/issues/1238): Add new `Rails/EnumSyntax`. ([@maxprokopiev][])

[koic]

@maxprokopiev ping.

[koic]

I opened #1336 based on your commit to include it in the upcoming new version planned for release soon. Thank you.