Fix ARP response after RCP factory reset, CC_ASSERT calls #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since p-net may be compiled without asserts (e.g. release builds for STM32Cube), it could be the case that expressions with side effects were not evaluated; this would cause incorrect behaviour. While the rt-kernel port does not use CC_ASSERT, it has also been changed in the same manner for consistency.
Automated RT-Tester: DCP_ResetToFactory (v2.44) When performing a Reset Communication Parameter factory reset, the IP suite is zeroed. However, this was only done to p-net's non-volatile storage. Thus, p-net would respond to ARP requests destined to the old IP address until the IP address is changed or after a reset. This commit also resets the network interface.
pyhys
approved these changes
Apr 17, 2024
hefloryd
approved these changes
Apr 24, 2024
pvedin
pushed a commit
to pvedin/p-net
that referenced
this pull request
Apr 30, 2024
rtlabs-com#576 added an additional call to pnal_set_ip_suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.