Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a recipe has a ptype, use it to set up the vetiver model #287

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

juliasilge
Copy link
Member

@juliasilge juliasilge commented Jul 19, 2024

Closes #286

The recipes tests now skip on older versions but I didn't bump in DESCRIPTION. Maybe I should just bump though, actually.

I did decide to bump the version for recipes in DESCRIPTION; I think that's better than trying to support both moving forward.

@juliasilge
Copy link
Member Author

@EmilHvitfeldt Let me know if you have any opinions on this!

Copy link
Collaborator

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so happy to see recipes ptype in use!

R/recipe.R Outdated Show resolved Hide resolved
Co-authored-by: Emil Hvitfeldt <[email protected]>
@juliasilge juliasilge merged commit a04511f into main Jul 19, 2024
9 checks passed
@juliasilge juliasilge deleted the add-recipes-ptype branch July 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recipes now support ptype extraction
2 participants