Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to rlang::expr_deparse() except for board_url() #257

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

juliasilge
Copy link
Member

Addresses these user-reported issues:

The change in #241 turned out to actually break generating the plumber files for more complex boards like S3 and similar. 😩

I need to think about testing across different board types in vetiver. The pins package is tested very extensively across all the backends but vetiver does not, and here it is the code that vetiver ran that was the problem. I could probably get away with mocking vetiver_pin_read() in such tests to avoid needing to call S3 like pins CI does.

@juliasilge
Copy link
Member Author

If I'm going to write some tests with mocking, I need to export new_board() from pins.

@juliasilge
Copy link
Member Author

I'm going to fix this bug now, and wait on the tests since I will need to do a pins release to write the tests.

@juliasilge juliasilge merged commit 2a094b5 into main Nov 8, 2023
9 checks passed
@juliasilge juliasilge deleted the fix-board-deparse-again branch November 8, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant