-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Mocks::Proxy
to make it easier to treat blocks similarly to args for expectations matchers like a_block
#1241
base: main
Are you sure you want to change the base?
Conversation
…tcher * cucumber feature passing * happy path unit specs passing * need help fixing sad path unit specs, currently marked pending
- Make api consistent in using `*args, &block` throughout
… delegate all @messages_received related logic to them
…ys) allowing usage of ReceivedMessages#all_args
…pectation? has to be lazily invoked
…age-from-Proxy - Add spec to cover stubs with block args - Pass block to MessageExpecation#match? consistently in ReceivedMessage
…k argument with a_block expectation set
@@ -122,3 +122,28 @@ Feature: Matching arguments | |||
""" | |||
When I run `rspec responding_differently_spec.rb` | |||
Then the examples should all pass | |||
|
|||
Scenario: Expecting a method invocatin with a block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"invocation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in 9bc5f79
…l that I missed out earlier
OK I have this green for all rubies except for 1.8.7, ree and jruby 1.7 (all three with the same red spec). I'm having trouble installing 1.8.7/ree on my box, will try with jruby 1.7. |
Ref the conversation #1237 (comment)
Redid the
a_block
change after refactoringMocks::Proxy
to make it easier to treat blocks similarly to args for expectations matchers likea_block
- this PR includes all the commits originally made in #1237