chore: remove TODO comments

rsocket · Jan 12, 2022 · d5059bf · d5059bf
1 parent ea42001
commit d5059bf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/packages/rsocket-adapter-async/src/lib/requesters/requestResponse.ts b/packages/rsocket-adapter-async/src/lib/requesters/requestResponse.ts
@@ -25,8 +25,6 @@ export default function requestResponse<TData, RData>(
     return new Promise((resolve, reject) => {
       rsocket.requestResponse(payload, {
         onNext(payload: Payload): void {
-          // TODO: is there data loss by only resolving with `payload.data`?
-          //   should metadata be included in the resolved value?
           resolve(outputCodec.decode(payload.data));
         },
         onComplete(): void {

diff --git a/packages/rsocket-adapter-async/src/lib/requesters/requestStream.ts b/packages/rsocket-adapter-async/src/lib/requesters/requestStream.ts
@@ -21,8 +21,6 @@ export default function requestStream<TData, RData>(
   ) {
     const exchangeFunction = (subscriber, initialRequestN) => {
       const payload = {
-        // TODO: should inputCodec be responsible for handling empty data?
-        // TODO: Buffer needs to be injectable to support browsers
         data: data ? inputCodec.encode(data) : Buffer.allocUnsafe(0),
         metadata: encodeCompositeMetadata(metadata),
       };