Implement an abstract keystore class + port fs + rpmdb keystores to it #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to return number of keys loaded but it didn't really mean anything, and so nothing was checking the results either. So for now keystore load simply always returns success, that's how it has technically always behaved anyway.
Add an abstract rpm::keystore class and port our existing rpmdb and fs keystores to that. The keystore code as such doesn't really change at all in here, the bigger change is the way it's initialized because it's an object instead of just an integer in the rpmts struct. As a kind of side-effect, we introduce the rpm:: namespace here. Fixes: rpm-software-management#3342
This is currently unused, move it last and give it a default value to avoid callers needing to bother. No functional changes.
pmatilai
requested review from
dmnks and
ffesti
and removed request for
a team and
dmnks
|
This is surprisingly straight forward. Guess all the refactoring in advance has paid off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beef is in the second commit, the other two are just minor refactoring (so yeah there was one more of those 😄 )
Fixes: #3342