Minor test-suite tweaks/fixes, volume VI #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't stop if there's a base tree already, this way we'll install any newly added packages while still letting DNF skip over those already installed. The original intent of this short-circuit conditional was to avoid the output noise but then, it's not really that bad and we'll avoid unnecessary rebuilds in the next commit anyway.
Turn the tree (mktree.output) into a proper build artifact and let cmake do its job in determining when to remake it, instead of doing that always. Keep the "tree" target though, it's still useful when you want to build the tree manually.
We want these to always be 0 so that cmake doesn't print an "error" when leaving the shell (if the last command happened to fail). However, since it's a cmake thing, handle that in cmake instead of mktree backends. No functional change, just cosmetic.
dmnks
force-pushed
the
test-tweaks-vol-6
branch
12 times, most recently
from
ce648c8
to
79fbd5a
Compare
That may well be a some kind of a record 😄 Better merge before you change your mind again... |
|
Yeah 😆 I realized some of the commits weren't quite right and also not strictly necessary either so I pulled them back. And then my traditional "crap, this commit message is confusing, reword it" kind of struggle 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minute cosmetic changes, just something that I stumbled across while working on #2691. Some of this preparatory work for #2691 though.