Review tests in microdnf directory #1579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests don't need to be separated anymore because dnf5 supports and uses installroot when running them. Stderr checking had to be amended for a couple reinstall tests. One install test (Install an RPM without null lines) was dropped.
- since dnf5 supports installroot we can drop the `@no_installroot` tag - `microdnf transaction is` had to be changed to `transaction is following` because the transaction formatting is different - `upgraded` Actions were dropped because they are not tracked in dnf5 step - stderr and stdout outputs had to be modified on several places - Fix `Scenario: multiline config for gpg works with local repo` by adding proper path to repos (the test wasn't running before)
- vars.feature: contained a test where installroot path was included twice (one automatically and one manually). - protect-running-kernel.feature: needs to exclude `dnf-ci-obsolere` in the background otherwise the obsolete package is installed right away. Apparently original microdnf didn't do that (but both old dnf and dnf5 do take the obsolete into account on install).
|
Is it really worth it to keep the microdnf tests in the separate microdnf directory if it's just an alias for the dnf5 command? In past, we had run tests explicitly with "dnf", "dnf-3" and "yum", maybe it was even possible to switch the command for all the tests, I am not sure exactly. But having the test at one place and only switching the command name seems better than to have a somewhat duplicate sets of tests. I can imagine it might be a lot of work to change it, but it would be more maintainable later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the tests are duplicate to regular dnf5 tests but they are run through the
microdnfcommand.