Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to match curl error messages #1556

Open
wants to merge 1 commit into
base: dnf-4-stack
Choose a base branch
from

Conversation

martinobanana
Copy link

Error messages in new curl changed and the test needed to be updated. The diffs were mostly "Couldn't" -> "Could not" and "host name" -> "hostname"

@martinobanana
Copy link
Author

This is actually a little bit tricky, it's the same commit I did for RHEL-10 (curl-8.9.1-4.el10.x86_64) where it works. But here it's complicated because due to how the outputs are checked (exact match) it depends on version of curl on the test system. Which can be different for all systems with dnf-4.

@kontura
Copy link
Contributor

kontura commented Oct 16, 2024

Oh, sorry, I totally forgot about this PR 🤦‍♂️. I did the same thing as part of #1569.

I am proposing to disable the tests with updated curl messages on Fedora < 41. That way they don't fail and going forward they will be run on all active fedoras again (in some time).

If you prefer we can finish the change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants