Add tests for supporting included configuration files #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkratoch
commented
Jul 27, 2023
Comment on lines
+447
to
+454
| # This fails, because the yum exclude overrides the filesystem exclude | ||
| # When I execute dnf with args "install filesystem" | ||
| # Then the exit code is 1 | ||
| # And stderr is | ||
| # """ | ||
| # Failed to resolve the transaction: | ||
| # Argument 'filesystem' matches only excluded packages. | ||
| # """ |
There was a problem hiding this comment.
I think the option (and probably others) should be appendable, the same way you can append it from the command line in dnf4. However, it currently isn't appendable even from the command line, so I wouldn't block the PR on it, just create an issue.
|
Closing in favor of #1373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires PR: rpm-software-management/dnf5#741