Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Warning: skipped PGP checks...' to expected outputs #1343

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

evan-goode
Copy link
Member

rpm-software-management/dnf5#697 adds a warning message when any PGP checks are skipped by gpgcheck=false. Some tests need to be updated to expect that warning on stderr.

Part of rpm-software-management/dnf5#617

@evan-goode evan-goode self-assigned this Jul 21, 2023
@evan-goode
Copy link
Member Author

I believe the remaining failure in download-binary-xml-base.feature would be fixed by rpm-software-management/createrepo_c#375.

@evan-goode
Copy link
Member Author

Yep, the integration tests pass locally.

@m-blaha
Copy link
Member

m-blaha commented Aug 1, 2023

Sorry, I checked only dnf5 tests and forgot about dnf5daemon. Let's merge this PR and I'll prepare a fix for the daemon.

@m-blaha m-blaha merged commit 5fcdc98 into rpm-software-management:main Aug 1, 2023
3 of 4 checks passed
@m-blaha
Copy link
Member

m-blaha commented Aug 1, 2023

I removed the stderr check step for scenarios shared between dnf5 and dnf5daemon: #1352
@evan-goode, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants