Skip to content

Commit

Permalink
Remove tests for installing packages via multiple paths
Browse files Browse the repository at this point in the history
When multiple paths to the same rpm is given, I believe there are two
valid approaches:
    1. Fail because of conflicting requests
    2. Install one of the packages (if they have the same checksum)

Currently dnf fails because of conflicting requests, but I don't think
there needs to be a test for that, since the other approach is not
strictly bad.
  • Loading branch information
pkratoch committed Oct 21, 2024
1 parent 5b74398 commit 2f4d757
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions dnf-behave-tests/dnf/install-path.feature
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,6 @@ Scenario: I can install an RPM from path, when specifying the RPM multiple times
| install | setup-0:2.12.1-1.fc29.noarch |


@xfail
Scenario: I can install an RPM from path, when specifying the RPM multiple times using different paths
Given I set working directory to "{context.dnf.fixturesdir}/repos/dnf-ci-fedora"
When I execute dnf with args "install noarch/setup-2.12.1-1.fc29.noarch.rpm {context.dnf.fixturesdir}/repos/dnf-ci-fedora/noarch/setup-2.12.1-1.fc29.noarch.rpm"
Then the exit code is 0
And Transaction is following
| Action | Package |
| install | setup-0:2.12.1-1.fc29.noarch |


@xfail
Scenario: I can install an RPM from path, when specifying the RPM multiple times using symlink
Given I copy file "{context.dnf.fixturesdir}/repos/dnf-ci-fedora/noarch/setup-2.12.1-1.fc29.noarch.rpm" to "/tmp/setup-2.12.1-1.fc29.noarch.rpm"
And I create symlink "/tmp/symlink.rpm" to file "/tmp/setup-2.12.1-1.fc29.noarch.rpm"
When I execute dnf with args "install {context.dnf.installroot}/tmp/setup-2.12.1-1.fc29.noarch.rpm {context.dnf.installroot}/tmp/symlink.rpm"
Then the exit code is 0
And Transaction is following
| Action | Package |
| install | setup-0:2.12.1-1.fc29.noarch |


Scenario: I can install an RPM from url, where url is http address
Given I use repository "dnf-ci-fedora" as http
And I execute dnf with args "install http://localhost:{context.dnf.ports[dnf-ci-fedora]}/noarch/setup-2.12.1-1.fc29.noarch.rpm"
Expand Down

0 comments on commit 2f4d757

Please sign in to comment.