Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code setting IC_DATA_CMD.RESTART bit #827

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove code setting IC_DATA_CMD.RESTART bit #827

wants to merge 4 commits into from

Commits on Aug 25, 2024

  1. Remove code setting IC_DATA_CMD.RESTART bit 

    According to the datasheet, a restart is automatically triggered "if
the transfer direction is changing from the previous command". The
RESTART bit is only needed to trigger an unconditional RESTART sequence.

According to the contract of I2c::transaction, "Data from
adjacent operations of the same type are sent after each other without
an SP or SR" and "Between adjacent operations of a different type an SR
and SAD+R/W is sent". This looks like it is exactly what the hardware
provides out of the box.

(See: https://docs.rs/embedded-hal/1.0.0/ebedded_hal/i2c/trait.I2c.html#tymethod.transaction)
    @jannic
    jannic committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    16fc26c View commit details
    Browse the repository at this point in the history

  2. Increase rtt buffer size for on-target tests 

    Some of the panic messages are longer than the default buffer, causing a lockup.
    @jannic
    jannic committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    82f076e View commit details
    Browse the repository at this point in the history

  3. Fix on-target tests

    @jannic
    jannic committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5046f14 View commit details
    Browse the repository at this point in the history

  4. Also apply changes to rp235x-hal

    @jannic
    jannic committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e7c6d14 View commit details
    Browse the repository at this point in the history