Copy pico_i2c_pio example from rp-hal #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
commented
May 15, 2022
| //! using the PIO peripheral as an I2C bus controller. | ||
| //! The pins used for the I2C can be remapped to any other pin available to the PIO0 peripheral. | ||
| //! | ||
| //! See the `Cargo.toml` file for Copyright and license details. |
There was a problem hiding this comment.
IIRC the example was originally written by you, @ithinuel, so I guess this line still applies even after moving the example here.
There was a problem hiding this comment.
That's correct.
https://github.com/rp-rs/rp-hal/commits/main/boards/rp-pico/examples/pico_i2c_pio.rs shows there has been some changes from @jonathanpallant and @VictorKoenders. We may need approval from them as well ?
There was a problem hiding this comment.
My change was only to update the uart API
jannic
referenced
this pull request
in jannic/rp-hal
Jun 4, 2022
This example should be moved to the i2c-pio crate: https://github.com/ithinuel/i2c-pio-rs/pull/6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in https://github.com/ithinuel/i2c-pio-rs/pull/5#issuecomment-1113087440 it might be sensible to move the example from rp-hal to this crate.
Unfortunately, to make it easy to compile it, several additional files are needed. I don't think adding these files will cause any real issues, but they clutter the repo and may be confusing. So I'm no longer convinced that his is the best option.