Defaulted default constructors to get both idioms right

roystgnr · Dec 13, 2018 · 8633d7d · 8633d7d
1 parent 001b588
commit 8633d7d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/src/numerics/include/metaphysicl/dualnumber.h b/src/numerics/include/metaphysicl/dualnumber.h
@@ -131,12 +131,6 @@ DualNumber<T,D>::operator=(const T2 & scalar)
 //
 // Member function definitions
 //
-
-template <typename T, typename D>
-inline
-DualNumber<T,D>::DualNumber() :
-  _val(), _deriv() {}
-
 template <typename T, typename D>
 template <typename T2>
 inline

diff --git a/src/numerics/include/metaphysicl/dualnumber_decl.h b/src/numerics/include/metaphysicl/dualnumber_decl.h
@@ -52,7 +52,7 @@ class DualNumber : public safe_bool<DualNumber<T,D> >
 
   typedef D derivatives_type;
 
-  DualNumber();
+  DualNumber() = default;
 
   template <typename T2>
   DualNumber(const T2& val);

diff --git a/src/numerics/include/metaphysicl/numberarray.h b/src/numerics/include/metaphysicl/numberarray.h
@@ -79,7 +79,7 @@ class NumberArray
     typedef NumberArray<N2, T> other;
   };
 
-  NumberArray() : _data() {}
+  NumberArray() = default;
 
   NumberArray(const T& val)
     { std::fill(_data, _data+N, val); }

diff --git a/src/numerics/include/metaphysicl/numbervector.h b/src/numerics/include/metaphysicl/numbervector.h
@@ -81,7 +81,7 @@ class NumberVector
     typedef NumberVector<N2, T> other;
   };
 
-  NumberVector() {}
+  NumberVector() = default;
 
   NumberVector(const T& val)
     { std::fill(_data, _data+N, val); }