Generate Telemetry Unit Labels Function #28
Conversation
Modeled off of the PositionReport class, I created a TelemetryReport and used similar serialization to create a working packet that was uploaded to aprs.fi for testing.
Committing initial code that supports the generation of an APRS unit/label string. This was testing by sending telemetry labels to APRS-IS and checked on aprs.fi. Not cleaned up yet.
Commented that the comma search at the end is due to the comma being able to change index due to a varying callsign length for the telemetry callsign. Also removed an unused comment variable. This code does NOT check for valid length of input data.
TelemetryEquationsReport will generate a string of equation parameters to scale telemetry data to.
This function sends out only digital IO status telemetry as well as a project name that effectively describes what the APRS station is meant to do.
Pulling in updates from upstream/master that check position coordinates.
Per @rossengeorgiev comments on rossengeorgiev#27 I now use a dictionary with lists to hold telemetry similar to how aprslib holds telemetry when parsed from comments.
Much more simple method of only having data in body be joined by commas and tacking that onto a packet type indicator to avoid having to remove a comma later. This was suggested in comments on rossengeorgiev#27.
After creating a value list I update the last item to itself be a list of items. This is so it may hold binary data for IO.
|
This PR no longer includes the original units/label code |
|
@rossengeorgiev yeah this branch is broken now with your update to #27. At some point in the near future I can merge your update of my telemetry packet into my other code. Since I have not just #28 telemetry/units but also Parameters, Labels, Equations, and project comments implemented as well should they just all go on one single PR? |
|
I need to do some refactoring to make Btw, all the current changes are on the |
|
OK @rossengeorgiev , So you know while this branch also has my original telemetry packet format which you updated it also contains my other implemented packets for reference. I'd love to get a PR in for these when I can. Let me know when you figure out your packet structure and I'll update them! https://github.com/kb1lqc/aprs-python/tree/faradayrfcustombitprojectname |
|
@rossengeorgiev checking in on this. Any luck with my previous comment? I'd be happy to do it myself too. If so any idea when these would get into the python module installable with pip? |
|
I've been sidetracked by other things. Have you seen whats on the https://github.com/rossengeorgiev/aprs-python/compare/packets You can parse and generate |
I branched from PR #27 commit to add a Telemetry Unit Label Function. This allows one to add unit labels to APRS telemetry. I checked this operation on APRS-IS.
APRS Specification:
APRS.fi accepted string test:
Let me know if this should be rolled into #27 instead. Figured I'd keep the PR's separate for new packets.