Allow unknown types in bag rewrite #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
requested review from
gbiggs and
jhdcs
and removed request for
a team
- Unhandled exception was causing rosbag2 converter or recorder to crash if the corresponding package for message type was not found. Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
|
Pulls: #1812
|
ahcorde
approved these changes
Sep 23, 2024
|
https://github.com/Mergifyio backport jazzy iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63)
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/message_definitions/local_message_definition_source.cpp
This was referenced Sep 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/message_definitions/local_message_definition_source.cpp # rosbag2_cpp/test/rosbag2_cpp/test_local_message_definition_source.cpp
MichaelOrlov
added a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63) Co-authored-by: Michael Orlov <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Allow unknown types in bag rewrite (#1812) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63)
MichaelOrlov
added a commit
that referenced
this pull request
Sep 24, 2024
* Allow unknown types in bag rewrite (#1812) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit cd7bd63) # Conflicts: # rosbag2_cpp/src/rosbag2_cpp/message_definitions/local_message_definition_source.cpp * Address merge conflicts during backporting Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Michael Orlov <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow
ros2 bag convertto process bag files with "unknown" message types.Unknown are the types which typesupport is not available during the bag conversion operation.
Also added proper handling for the
ament_index_cpp::PackageNotFoundErrorexception throwing from theament_index_cpp::get_package_share_directory(package);. It was causing abnormal converter or recorder termination if the package for message definition was not found in ament_index.ros2 bag convertignoring messages with unknown types #1811