Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global CI job for infrastructure packages #308

Draft
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 25, 2024

The intent for this job is to regularly build and test the bleeding edge of all of our infrastructure packages. Because these packages aren't part of any ROS distribution, the development tip is not regularly tested.

As we narrow in on a blessed development environment for our infrastructure packages as a whole (what linters/plugins are expected), we can add more packages to this job and tweak the build/test args to expand our coverage. This is a pretty good starting point, but there are notably absent packages like ros_buildfarm itself, which doesn't work due to setuptools compatibility.

Requires: ros-infrastructure/ros_buildfarm#1056
Requires: ros-infrastructure/ros_buildfarm#1057
Staging deployment: https://build.test.ros2.org/job/ci__infra_ubuntu_noble_amd64/

@cottsay cottsay self-assigned this Jun 25, 2024
@@ -0,0 +1,195 @@
%YAML 1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to host the repos file in the ros_buildfarm_config repository? I wouldn't want to create a repo just for it but I think https://github.com/ros-infrastructure/ci would also be a candidate or hosting repos files as part of the repository and web site that we'll need to host for the OSRA Infrastructure charter compliance.

I'm mostly concerned with scale if we begin to add other global CI to the build farm but that concern is likely unfounded so this is not a binding question.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds fine to me. It also decouples this change from ros-infrastructure/ros_buildfarm#1057.

build_environment_variables:
PYTHONWARNINGS: 'ignore:pkg_resources::'
build_tool: colcon
build_tool_test_args: '--event-handler console_stderr- console_cohesion+ --executor parallel --python-testing pytest --pytest-args -k "not test_spell_check" --packages-skip superflore'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is superflore being skipped because tests aren't passing on HEAD?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. I think at least some of them may need a functioning container engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants