Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a memcmp for the expected symbol name. #100

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Use a memcmp for the expected symbol name. #100

merged 2 commits into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. Use a memcmp for the expected symbol name. 

    I believe that g++ does not guarantee what a particular
symbol name will be.  Thus, in g++ 11.4.0 (what is in
Ubuntu 22.04), the symbol name here ended with "#2", while
in g++ 13.2.0 (what is in Ubuntu 24.04), the symbol name
ends with "#1".  Given that we can't guarantee this, just
search for the first part of the name up to the number,
which should be good enough for this test.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    32aff54 View commit details
    Browse the repository at this point in the history

  2. Add in a comment. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    84b93a5 View commit details
    Browse the repository at this point in the history