-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add article on checking package build status to Releasing guide. #4621
base: rolling
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,45 @@ | ||||||
Check package build status | ||||||
========================== | ||||||
|
||||||
Released ROS 2 packages with binary releases enabled are built on the `ROS 2 build farm <https://build.ros2.org>`_. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Drawing this out for the less versed users. |
||||||
|
||||||
Email notifications | ||||||
------------------- | ||||||
|
||||||
Maintainers of a released package will receive email notifications from the ROS 2 build farm, specifically ``[email protected]`` when builds fail or succeed after failure. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this e-mail keyed to? The package.xml I presume? It would be good to remind people where that address is set. Can more than one person be notified? |
||||||
The email notification will include a log excerpt and a link to the failing build in the ROS 2 build farm web interface. | ||||||
|
||||||
|
||||||
Build farm rosdistro status pages | ||||||
--------------------------------- | ||||||
|
||||||
The ROS 2 build farm web interface was not designed for the scale of jobs on the build farm. | ||||||
Navigating to specific builds using the web interface is cumbersome and generates unnecessary load and thus is not recommended. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
The ROS 2 build farm repository hosts several status pages which are used by the ROS core team and ROS bosses. | ||||||
These status pages can be used by package maintainers as well. | ||||||
|
||||||
ROS 2 status pages are hosted at `<https://repo.ros2.org/status_page>`_, which contains an autoindex of all current status pages. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
The status pages which are most relevant to package maintainers are the "release status" pages which are named ``ros_${ROS_DISTRO}_${TARGET}.html``. | ||||||
The ``${ROS_DISTRO}`` value is the codename of a specific ROS distribution and the ``${TARGET}`` value is taken from the specific release build configuration file in the `ROS 2 build farm configuration <https://github.com/ros2/ros_buildfarm_config>`_. | ||||||
Current target values are | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
- ``default`` for the AMD64 Ubuntu release supported by the ROS distribution, | ||||||
- ``rhel`` for the AMD64 RHEL-compatible Enterprise Linux release supported by the ROS odistribution. | ||||||
- ``XYv8`` for the ARM64 Ubuntu release supported by the ROS distribution. | ||||||
The first two characters indicate the operating system distribution (``u`` for Ubuntu, ``d`` for Debian) and release codename (e.g. ``j`` for Ubuntu 22.04 Jammy, ``n`` for Ubuntu 24.04 Noble), the latter two characters ``v8`` refer to the target architecture ARM64 by its historic Debian designation ``armv8``. | ||||||
|
||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
To find information about your package in a specific ROS distribution such as Rolling Ridley on Ubuntu AMD64, use the ``ros_rolling_default.html`` status page. | ||||||
|
||||||
Examples | ||||||
^^^^^^^^ | ||||||
|
||||||
Fixed package | ||||||
.. | ||||||
TODO(nuclearsandwich) this is just filler to prove images work. | ||||||
Needs elaboration | ||||||
|
||||||
.. image:: Check-package-build-status/images/fixed_package.png | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Honestly, I think a diagram here may be easier to read here than displaying the images and then trying to describe what's going on. Is it easy to maintain, not really, but it is a lot clearer. If I had a better idea about what is going on I could whip something up in Canva really quick. What are you doing this Friday at 11am? =) |
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God, we need a style guide. Is it Build Farm or Buildfarm or build farm?!